Examples Changes and move VMSS list operation inside fleets resource#29243
Merged
ms-bogdan-rotaru merged 3 commits intomainfrom Jun 13, 2024
Merged
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
Swagger Validation Report
|
| Compared specs (v0.10.9) | new version | base version |
|---|---|---|
| azurefleet.json | 2023-11-01-preview(4e9317f) | 2023-11-01-preview(main) |
| azurefleet.json | 2024-05-01-preview(4e9317f) | 2024-05-01-preview(main) |
| Rule | Message |
|---|---|
1008 - ModifiedOperationId |
The operation id has been changed from 'VirtualMachineScaleSets_ListByFleet' to 'Fleets_ListVirtualMachineScaleSets'. This will impact generated code. New: Microsoft.AzureFleet/preview/2023-11-01-preview/azurefleet.json#L438:7 Old: Microsoft.AzureFleet/preview/2023-11-01-preview/azurefleet.json#L441:7 |
1008 - ModifiedOperationId |
The operation id has been changed from 'VirtualMachineScaleSets_ListByFleet' to 'Fleets_ListVirtualMachineScaleSets'. This will impact generated code. New: Microsoft.AzureFleet/preview/2024-05-01-preview/azurefleet.json#L417:7 Old: Microsoft.AzureFleet/preview/2024-05-01-preview/azurefleet.json#L420:7 |
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️CredScan succeeded [Detail] [Expand]
There is no credential detected.
️⚠️LintDiff: 0 Warnings warning [Detail]
| Compared specs (v2.2.2) | new version | base version |
|---|---|---|
| package-preview-2023-11 | package-preview-2023-11(4e9317f) | package-preview-2023-11(main) |
| package-preview-2024-05 | package-preview-2024-05(4e9317f) | package-preview-2024-05(main) |
The following errors/warnings exist before current PR submission:
| Rule | Message |
|---|---|
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.AzureFleet/preview/2023-11-01-preview/azurefleet.json#L437 |
|
| A nested resource type's List operation must include all the parent segments in its api path. Location: Microsoft.AzureFleet/preview/2024-05-01-preview/azurefleet.json#L416 |
|
| Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum. Location: Microsoft.AzureFleet/preview/2024-05-01-preview/azurefleet.json#L932 |
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️PoliCheck succeeded [Detail] [Expand]
Validation passed for PoliCheck.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️Lint(RPaaS) succeeded [Detail] [Expand]
Validation passes for Lint(RPaaS).
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Swagger Generation Artifacts
|
Generated ApiView
|
This was referenced May 28, 2024
Member
Author
|
ListVMSS api will be used with fleets resource and we don't want VMSS to be exposed as a new resource. Customers are using it the way it is being defined here and it is a bug fix in swagger modeling. Please help in approving the breaking change. |
ykh015
approved these changes
May 28, 2024
ykh015
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.